Don't keep a separate list of ignored-when-colors-disabled longhands.
ClosedPublic
Actions

Authored by emilio on Nov 2 2018, 1:26 AM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rMOZILLACENTRALdd629ef17f62: Bug 1502751 - Don't keep a separate list of ignored-when-colors-disabled…

Bugzilla Bug ID

1502751

Summary

Most of the change is moving sets around to be static functions on
LonghandIdSet. I think I like that pattern, but I can also make the new set a
global static and add mako code to be pub or something.

Though I think the LonghandIdSet::foo().contains(..) pattern is nice to read :)

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Nov 2 2018, 1:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2018, 1:26 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 2 2018, 1:26 AM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B18986: Diff 30882.Nov 2 2018, 1:26 AM

emilio requested review of this revision.Nov 2 2018, 1:26 AM

This pattern looks nice to me too.

This revision is now accepted and ready to land.Nov 5 2018, 12:16 AM

Closed by commit rMOZILLACENTRALdd629ef17f62: Bug 1502751 - Don't keep a separate list of ignored-when-colors-disabled… (authored by emilio). · Explain WhyNov 5 2018, 9:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

servo/

components/

style/

properties/

properties.mako.rs

69 lines

rule_tree/

mod.rs

23 lines

Diff 31695

View Options

servo/components/style/properties/properties.mako.rs