Paths

Table of Contentst

Differential D10652

Bug 1504034 - Part 3: Store the Rust QuotePair slice as the computed quotes value in Gecko style structs
ClosedPublic
Actions

Authored by heycam on Nov 2 2018, 1:02 AM.

Tags

None

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rMOZILLACENTRAL2e5a8258ba69: Bug 1504034 - Part 3: Store the Rust QuotePair slice as the computed quotes…

Bugzilla Bug ID

Summary

Depends on D10651

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

heycam created this revision.Nov 2 2018, 1:02 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2018, 1:02 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 2 2018, 1:02 AM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B18985: Diff 30881.Nov 2 2018, 1:02 AM

heycam requested review of this revision.Nov 2 2018, 1:02 AM

Herald added a subscriber: emilio. · View Herald TranscriptNov 2 2018, 1:02 AM

emilio accepted this revision as: emilio.Nov 5 2018, 11:04 AM

emilio added inline comments.

servo/ports/geckolib/glue.rs
6027	It's a bit unfortunate to always allocate here just to get it copied again to a text node. But I guess quotes are generally small. nit: This function should be unsafe, and I think you can just do `(*result).write_str(quote).unwrap()`, which maybe is a bit cleaner.

emilio removed a reviewer: Restricted Project.Nov 5 2018, 11:04 AM

This revision is now accepted and ready to land.Nov 5 2018, 11:04 AM

heycam marked an inline comment as done.Nov 6 2018, 10:58 PM

heycam updated this revision to Diff 32724.Nov 6 2018, 10:59 PM

heycam added a reviewer: Restricted Project.

This revision now requires review to proceed.Nov 6 2018, 10:59 PM

heycam removed a reviewer: Restricted Project.Nov 6 2018, 11:02 PM

This revision is now accepted and ready to land.Nov 6 2018, 11:02 PM

Closed by commit rMOZILLACENTRAL2e5a8258ba69: Bug 1504034 - Part 3: Store the Rust QuotePair slice as the computed quotes… (authored by heycam). · Explain WhyNov 6 2018, 11:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

layout/

base/

nsLayoutUtils.cpp

3 lines

2 lines

nsQuoteList.cpp

30 lines

style/

GeckoBindings.h

4 lines

GeckoBindings.cpp

10 lines

ServoArcTypeList.h

1 line

ServoBindings.h

9 lines

ServoBindings.toml

2 lines

nsStyleStruct.h

32 lines

nsStyleStruct.cpp

26 lines

servo/

components/

style/

gecko/

5 lines

gecko_bindings/

sugar/

15 lines

properties/

34 lines

values/

computed/

3 lines

2 lines

ports/

geckolib/

53 lines

Diff 32731

layout/base/nsLayoutUtils.cpp

Loading...

layout/base/nsQuoteList.h

Loading...

layout/base/nsQuoteList.cpp

Loading...

layout/style/GeckoBindings.h

Loading...

layout/style/GeckoBindings.cpp

Loading...

layout/style/ServoArcTypeList.h

Loading...

layout/style/ServoBindings.h

Loading...

layout/style/ServoBindings.toml

Loading...

layout/style/nsStyleStruct.h

Loading...

layout/style/nsStyleStruct.cpp

Loading...

servo/components/style/gecko/arc_types.rs

Loading...

servo/components/style/gecko_bindings/sugar/refptr.rs

Loading...

servo/components/style/properties/gecko.mako.rs

Loading...

servo/components/style/values/computed/list.rs

Loading...

servo/components/style/values/computed/mod.rs

Loading...

servo/ports/geckolib/glue.rs

Loading...