Bug 1504034 - Part 1: Make quotes property representation allocate less
ClosedPublic
Actions

Authored by heycam on Nov 2 2018, 1:02 AM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rMOZILLACENTRAL84a728ecbaa4: Bug 1504034 - Part 1: Make quotes property representation allocate less r=emilio

Bugzilla Bug ID

1504034

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

heycam created this revision.Nov 2 2018, 1:02 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2018, 1:02 AM

heycam added a child revision: D10651: Bug 1504034 - Part 2: Use Servo to serialize computed quotes values.Nov 2 2018, 1:02 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 2 2018, 1:02 AM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B18983: Diff 30879.Nov 2 2018, 1:02 AM

heycam requested review of this revision.Nov 2 2018, 1:02 AM

Herald added a subscriber: emilio. · View Herald TranscriptNov 2 2018, 1:02 AM

r=me with that, maybe, and / or with a followup to change a few / a bunch of our types to use that :)

servo/components/style/values/specified/list.rs
92	Should be possible to use `Arc<[QuotePair]>` directly these days, using: Arc::from(quotes.into_boxed_slice()) See https://github.com/rust-lang/rfcs/blob/master/text/1845-shared-from-slice.md

emilio removed a reviewer: Restricted Project.Nov 2 2018, 1:09 AM

This revision is now accepted and ready to land.Nov 2 2018, 1:09 AM

heycam marked 2 inline comments as done.Nov 4 2018, 10:49 PM

heycam added inline comments.

servo/components/style/values/specified/list.rs
92	Filed bug 1504571.

heycam updated this revision to Diff 32722.Nov 6 2018, 10:59 PM

heycam retitled this revision from Bug 1504034 - Part 1: Make quotes property reprsentation allocate less to Bug 1504034 - Part 1: Make quotes property representation allocate less.

heycam added a reviewer: Restricted Project.

heycam marked an inline comment as done.

This revision now requires review to proceed.Nov 6 2018, 10:59 PM

heycam removed a reviewer: Restricted Project.Nov 6 2018, 11:03 PM

This revision is now accepted and ready to land.Nov 6 2018, 11:03 PM

Closed by commit rMOZILLACENTRAL84a728ecbaa4: Bug 1504034 - Part 1: Make quotes property representation allocate less r=emilio (authored by heycam). · Explain WhyNov 6 2018, 11:05 PM

This revision was automatically updated to reflect the committed changes.