Details

Reviewers

Commits

Restricted Diffusion Commit
rMOZILLACENTRALffb8562ce45d: Bug 1500107 - Fix the default behavior of scale:<number>{1}. r=birtles

Bugzilla Bug ID

1500107

Summary

The current spec says: "If only the X value is given, the Y value
defaults to the same value.", so we should update the behavior.

Besides, we also update the serialization, so we serialization both
specified and computed value by servo. We enable the preference
for all the css-transforms, so some of them are passed now.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

boris created this revision.Nov 1 2018, 11:33 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2018, 11:33 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Nov 1 2018, 11:33 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B18970: Diff 30862.Nov 1 2018, 11:33 PM

boris requested review of this revision.Nov 1 2018, 11:34 PM

Herald added a subscriber: emilio. · View Herald TranscriptNov 1 2018, 11:34 PM

boris added a reviewer: birtles.Nov 1 2018, 11:35 PM

Forgot to update some testcases.

The code changes look good but I'll wait to see the updated tests before adding r+.

In D10638#255784, @birtles wrote:

The code changes look good but I'll wait to see the updated tests before adding r+.

Ya, I forgot to update nsComputedDOMStyle::DoGetScale(), which may trigger an assertion while calling getComputedStyle(). Maybe it's worth to drop the gecko code and serialize the individual transforms by servo. I'd like to try this.

boris updated this revision to Diff 32067.Nov 5 2018, 9:16 PM

boris edited the summary of this revision. (Show Details)

boris updated this revision to Diff 32077.Nov 5 2018, 9:38 PM

boris updated this revision to Diff 32080.Nov 5 2018, 9:40 PM

boris updated this revision to Diff 32115.Nov 5 2018, 10:21 PM

boris updated this revision to Diff 32160.Nov 6 2018, 12:13 AM

Thanks for working through all the spec issues for this!

testing/web-platform/meta/css/css-transforms/parsing/rotate-parsing-valid.html.ini
14–21	So it looks like some of the individual transform tests are still failing? But bug 1500107 is about fixing the tests for individual transform properties? Do we need to file a follow up bug for the remaining failures?

This revision is now accepted and ready to land.Nov 6 2018, 12:45 AM

boris marked 2 inline comments as done.Nov 6 2018, 12:50 AM

boris added inline comments.

testing/web-platform/meta/css/css-transforms/parsing/rotate-parsing-valid.html.ini
14–21	For the rotation, CJ didn't implement it for {x\|y\|z} keywords, so I filed Bug 1504327 to tracking this. I haven't checked `translate`, so maybe I should file a different bug for it after going through all.

boris updated this revision to Diff 32559.Nov 6 2018, 6:40 PM

boris edited the summary of this revision. (Show Details)

boris marked an inline comment as done.

boris edited the summary of this revision. (Show Details)Nov 6 2018, 11:44 PM

Closed by commit rMOZILLACENTRALffb8562ce45d: Bug 1500107 - Fix the default behavior of scale:<number>{1}. r=birtles (authored by boris). · Explain WhyNov 6 2018, 11:45 PM

This revision was automatically updated to reflect the committed changes.

Bug 1500107 - Fix the default behavior of scale:<number>{1}.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 32740

layout/reftests/w3c-css/submitted/transforms/individual-transform-1-ref.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-1.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2-ref.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2a.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2b.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2c.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2d.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2e.html

layout/reftests/w3c-css/submitted/transforms/reftest.list

layout/style/ServoCSSPropList.mako.py

layout/style/nsComputedDOMStyle.h

layout/style/nsComputedDOMStyle.cpp

servo/components/style/properties/helpers/animated_properties.mako.rs

servo/components/style/values/computed/transform.rs

servo/components/style/values/generics/transform.rs

servo/components/style/values/specified/transform.rs

testing/web-platform/meta/css/css-transforms/dir.ini

testing/web-platform/meta/css/css-transforms/animation/rotate-interpolation.html.ini

testing/web-platform/meta/css/css-transforms/animation/scale-interpolation.html.ini

testing/web-platform/meta/css/css-transforms/animation/translate-interpolation.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-1.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2a.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2b.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2c.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2d.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2e.html.ini

testing/web-platform/meta/css/css-transforms/parsing/rotate-parsing-valid.html.ini

testing/web-platform/meta/css/css-transforms/parsing/scale-parsing-valid.html.ini

testing/web-platform/meta/css/css-transforms/parsing/translate-parsing-valid.html.ini

testing/web-platform/meta/css/css-transforms/transforms-support-calc.html.ini

testing/web-platform/tests/css/css-transforms/parsing/scale-parsing-valid.html

testing/web-platform/tests/web-animations/animation-model/animation-types/property-types.js

Bug 1500107 - Fix the default behavior of scale:<number>{1}.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32740

layout/reftests/w3c-css/submitted/transforms/individual-transform-1-ref.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-1.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2-ref.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2a.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2b.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2c.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2d.html

layout/reftests/w3c-css/submitted/transforms/individual-transform-2e.html

layout/reftests/w3c-css/submitted/transforms/reftest.list

layout/style/ServoCSSPropList.mako.py

layout/style/nsComputedDOMStyle.h

layout/style/nsComputedDOMStyle.cpp

servo/components/style/properties/helpers/animated_properties.mako.rs

servo/components/style/values/computed/transform.rs

servo/components/style/values/generics/transform.rs

servo/components/style/values/specified/transform.rs

testing/web-platform/meta/css/css-transforms/__dir__.ini

testing/web-platform/meta/css/css-transforms/animation/rotate-interpolation.html.ini

testing/web-platform/meta/css/css-transforms/animation/scale-interpolation.html.ini

testing/web-platform/meta/css/css-transforms/animation/translate-interpolation.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-1.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2a.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2b.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2c.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2d.html.ini

testing/web-platform/meta/css/css-transforms/individual-transform/individual-transform-2e.html.ini

testing/web-platform/meta/css/css-transforms/parsing/rotate-parsing-valid.html.ini

testing/web-platform/meta/css/css-transforms/parsing/scale-parsing-valid.html.ini

testing/web-platform/meta/css/css-transforms/parsing/translate-parsing-valid.html.ini

testing/web-platform/meta/css/css-transforms/transforms-support-calc.html.ini

testing/web-platform/tests/css/css-transforms/parsing/scale-parsing-valid.html

testing/web-platform/tests/web-animations/animation-model/animation-types/property-types.js

Bug 1500107 - Fix the default behavior of scale:<number>{1}.
ClosedPublic
Actions

Revision Contents
Changeset List

testing/web-platform/meta/css/css-transforms/dir.ini