Paths

Table of Contentst

Differential D103461

Bug 1631061 [Wayland] Clear clipboard content when gtk_clipboard_request_contents() fails, r?jhorak
ClosedPublic
Actions

Authored by stransky on Jan 29 2021, 11:13 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, May 25, 9:12 PM

	Unknown Object (File)
	Jan 17 2025, 9:59 PM

	Unknown Object (File)
	Jul 14 2024, 1:00 AM

Subscribers

Details

Reviewers

Commits

rMOZILLACENTRAL23701e398495: Bug 1631061 [Wayland] Clear clipboard content when…

Bugzilla Bug ID

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 282208
Build 374942: arc lint + arc unit

Event Timeline

stransky created this revision.Jan 29 2021, 11:13 AM

Herald added a project: secure-revision. · View Herald TranscriptJan 29 2021, 11:13 AM

Harbormaster completed remote builds in B281898: Diff 392509.Jan 29 2021, 11:13 AM

phab-bot published this revision for review.Jan 29 2021, 11:13 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added subscribers: emilio, karlt. · View Herald TranscriptJan 29 2021, 11:13 AM

Code analysis found 1 defect in the diff 392509:

1 defect found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

jhorak accepted this revision.Jan 29 2021, 11:40 AM

This revision is now accepted and ready to land.Jan 29 2021, 11:40 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other.

jhorak added a project: testing-exception-unchanged (Doesn't change behavior for users).Jan 29 2021, 11:40 AM

Herald removed a project: needs-testing-tag. · View Herald TranscriptJan 29 2021, 11:40 AM

Closed by commit rMOZILLACENTRAL23701e398495: Bug 1631061 [Wayland] Clear clipboard content when… (authored by stransky). · Explain WhyJan 29 2021, 12:00 PM

This revision was automatically updated to reflect the committed changes.

stransky added a commit: rMOZILLACENTRAL23701e398495: Bug 1631061 [Wayland] Clear clipboard content when….

Harbormaster completed remote builds in B282208: Diff 392515.Feb 1 2021, 2:14 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

widget/

gtk/

nsClipboardWayland.cpp

50 lines

0%

Loading...

Diff 392515

widget/gtk/nsClipboardWayland.cpp

Loading...