Page MenuHomePhabricator
Differential D10327

Bug 1497076 - Handle reversed ranges in @font-face descriptors
ClosedPublic
Actions

Authored by heycam on Oct 31 2018, 7:29 AM.

Details

Reviewers
jfkthame
Commits
Restricted Diffusion Commit
rMOZILLACENTRAL9536fe8330a8: Bug 1497076 - Handle reversed ranges in @font-face descriptors r=jfkthame
Bugzilla Bug ID
1497076

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

heycam created this revision.Oct 31 2018, 7:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2018, 7:29 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 31 2018, 7:29 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B18476: Diff 29950.Oct 31 2018, 7:29 AM
heycam requested review of this revision.Oct 31 2018, 7:29 AM
Herald added a subscriber: emilio. · View Herald TranscriptOct 31 2018, 7:29 AM
jfkthame accepted this revision.Oct 31 2018, 10:40 AM

Makes sense to me, thanks.

(Actually, it's interesting to note that this differs from how codepoints in unicode-range are handled; in that case, the spec says "the end codepoint must be greater than or equal to the start codepoint", otherwise the range would be invalid. But that's a matter for the spec, if anything.)

This revision is now accepted and ready to land.Oct 31 2018, 10:40 AM
Closed by commit rMOZILLACENTRAL9536fe8330a8: Bug 1497076 - Handle reversed ranges in @font-face descriptors r=jfkthame (authored by heycam). · Explain WhyOct 31 2018, 10:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
servo/
components/
style/
23 lines
testing/
web-platform/
tests/
css/
css-fonts/
variations/
39 lines
56 lines

Diff 30298

View Options

servo/components/style/font_face.rs

Loading...
View Options

testing/web-platform/tests/css/css-fonts/variations/font-descriptor-range-reversed-ref.html

Loading...
View Options

testing/web-platform/tests/css/css-fonts/variations/font-descriptor-range-reversed.html

Loading...
Privacy · Cookies · Legal