Page MenuHomePhabricator
Differential D10303

Bug 1501116 - Part 1: Add a special list for cbindgen types to avoid generating redundant rust types.
ClosedPublic
Actions

Authored by boris on Oct 30 2018, 9:44 PM.

Details

Reviewers
emilio
Commits
Restricted Diffusion Commit
rMOZILLACENTRALfd02ae8fbc9b: Bug 1501116 - Part 1: Add a special list for cbindgen types to avoid generating…
Bugzilla Bug ID
1501116
Summary

We will blacklist this type and add a module raw line to map the gecko
type to its rust type (as an alias).

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

boris created this revision.Oct 30 2018, 9:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2018, 9:44 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 30 2018, 9:44 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B18400: Diff 29816.Oct 30 2018, 9:44 PM
boris requested review of this revision.Oct 30 2018, 9:44 PM
Herald added a subscriber: emilio. · View Herald TranscriptOct 30 2018, 9:44 PM
boris added a child revision: D10304: Bug 1501116 - Part 2: Use alias for StyleAppearance..Oct 30 2018, 9:44 PM
emilio accepted this revision.Oct 30 2018, 9:54 PM
emilio added inline comments.
servo/components/style/build_gecko.rs
398

Given you're only using the rightmost part of the name, you may want to just use gecko = "StyleComputedTimingFunction" instead of prefixing all of them with mozilla::. That can also be a followup patch if you want instead of rewriting all your patches separately. rs=me on that one.

This revision is now accepted and ready to land.Oct 30 2018, 9:54 PM
boris updated this revision to Diff 29832.Oct 30 2018, 9:56 PM

Revision updated.

Harbormaster completed remote builds in B18409: Diff 29832.Oct 30 2018, 9:56 PM
boris marked an inline comment as done.Oct 30 2018, 9:58 PM
boris added inline comments.
servo/components/style/build_gecko.rs
398

OK. I will add one extra patch for this.

boris updated this revision to Diff 29934.Oct 31 2018, 6:19 AM
boris marked an inline comment as done.

Revision updated.

Harbormaster completed remote builds in B18464: Diff 29934.Oct 31 2018, 6:19 AM
Closed by commit rMOZILLACENTRALfd02ae8fbc9b: Bug 1501116 - Part 1: Add a special list for cbindgen types to avoid generating… (authored by boris). · Explain WhyOct 31 2018, 6:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
layout/
style/
7 lines
servo/
components/
style/
6 lines

Diff 30203

View Options

layout/style/ServoBindings.toml

Loading...
View Options

servo/components/style/build_gecko.rs

Loading...
Privacy · Cookies · Legal