Page MenuHomePhabricator

Update cbindgen due to breaking change.
ClosedPublic

Authored by emilio on Oct 30 2018, 9:21 PM.

Details

Reviewers
boris
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rMOZILLACENTRAL5b0e4820c7fb: Bug 1503401 - Update cbindgen due to breaking change. r=boris
Bugzilla Bug ID
1503401
Summary

https://github.com/eqrion/cbindgen/pull/233 changed the way one of the options
we use work.

I think the new behavior is better, but we should do this sooner rather than
later, and fix broken builds.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Oct 30 2018, 9:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2018, 9:21 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 30 2018, 9:21 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
emilio requested review of this revision.Oct 30 2018, 9:21 PM
boris accepted this revision.Oct 30 2018, 9:25 PM

Oh, I see, so we don't need to add the prefix in cbindgen.toml. Thanks for fixing this.

This revision is now accepted and ready to land.Oct 30 2018, 9:25 PM
This revision was automatically updated to reflect the committed changes.