Page MenuHomePhabricator
Differential D101536

Bug 1684365 - Add a null pointer check so that Firefox won't crash when it can't initialize mRemoteServer
ClosedPublic
Actions

Authored by mh on Jan 13 2021, 2:17 AM.

Details

Reviewers
stransky
Commits
rMOZILLACENTRAL1edc48b99c80: Bug 1684365 - Add a null pointer check so that Firefox won't crash when it…
Bugzilla Bug ID
1684365
Summary

Firefox 84.0.1 crashes under Gentoo Linux if it is started in
Wayland mode and if it was compiled WITH Wayland support and
WITHOUT dbus support.

I traced down the problem to line 172 of
toolkit/components/remote/nsRemoteService.cpp:

nsresult rv = mRemoteServer->Startup(mProgram.get(), mProfile.get());

mRemoteServer is NULL and Firefox crashes.

This patch adds a NULL pointer check before that line.

See:

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 280350
Build 373019: arc lint + arc unit

Event Timeline

mh created this revision.Jan 13 2021, 2:17 AM
Herald added a project: secure-revision. · View Herald TranscriptJan 13 2021, 2:17 AM
Harbormaster completed remote builds in B276047: Diff 385620.Jan 13 2021, 2:18 AM
phab-bot published this revision for review.Jan 13 2021, 2:18 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
stransky accepted this revision.Jan 25 2021, 9:29 AM
This revision is now accepted and ready to land.Jan 25 2021, 9:29 AM
Herald added a project: needs-testing-tag. · View Herald TranscriptJan 25 2021, 9:29 AM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other.

Closed by commit rMOZILLACENTRAL1edc48b99c80: Bug 1684365 - Add a null pointer check so that Firefox won't crash when it… (authored by mh). · Explain WhyJan 25 2021, 9:35 AM
This revision was automatically updated to reflect the committed changes.
mh added a commit: rMOZILLACENTRAL1edc48b99c80: Bug 1684365 - Add a null pointer check so that Firefox won't crash when it….

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
toolkit/
components/
remote/
4 lines14%
Loading...

Diff 390191

View Options

toolkit/components/remote/nsRemoteService.cpp

Loading...
Privacy · Cookies · Legal