Page MenuHomePhabricator
Differential D10140

Bug 1501116 - Part 6: Use alias for StylePathCommand.
ClosedPublic
Actions

Authored by boris on Oct 30 2018, 12:56 AM.

Details

Reviewers
emilio
Commits
Restricted Diffusion Commit
rMOZILLACENTRAL16dc8e99aab0: Bug 1501116 - Part 6: Use alias for StylePathCommand. r=emilio
Bugzilla Bug ID
1501116
Summary

So we could drop transmute in svg_path related functions.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

boris created this revision.Oct 30 2018, 12:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 30 2018, 12:56 AM
boris added a child revision: D10141: Bug 1501116 - Part 3: Use alias for StyleDisplay and StyleDisplayMode..Oct 30 2018, 12:56 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 30 2018, 12:56 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Harbormaster completed remote builds in B18121: Diff 29356.Oct 30 2018, 12:56 AM
boris requested review of this revision.Oct 30 2018, 12:56 AM
Herald added a subscriber: emilio. · View Herald TranscriptOct 30 2018, 12:56 AM
boris updated this revision to Diff 29821.Oct 30 2018, 9:45 PM

Revision updated.

Harbormaster completed remote builds in B18405: Diff 29821.Oct 30 2018, 9:45 PM
boris retitled this revision from Bug 1501116 - Part 1: Map StylePathCommand to specified::PathCommand to Bug 1501116 - Part 6: Use alias for StylePathCommand..Oct 30 2018, 9:45 PM
boris edited the summary of this revision. (Show Details)
boris added a child revision: D10305: Bug 1501116 - Part 7: Use alias for StyleUnicodeRange..
boris removed child revisions: D10305: Bug 1501116 - Part 7: Use alias for StyleUnicodeRange., D10141: Bug 1501116 - Part 3: Use alias for StyleDisplay and StyleDisplayMode..Oct 30 2018, 9:48 PM
boris added a parent revision: D10142: Bug 1501116 - Part 5: Use alias for StyleFillRule..
boris added a child revision: D10305: Bug 1501116 - Part 7: Use alias for StyleUnicodeRange..
boris updated this revision to Diff 29837.Oct 30 2018, 9:56 PM

Revision updated.

Harbormaster completed remote builds in B18414: Diff 29837.Oct 30 2018, 9:56 PM
boris added a reviewer: emilio.Oct 30 2018, 9:59 PM
emilio accepted this revision.Oct 30 2018, 10:10 PM
emilio added inline comments.
servo/components/style/gecko/conversions.rs
708

nit: Instead of map(|&v| v), I think cloned() is a bit nicer, but not a big deal.

servo/components/style/properties/gecko.mako.rs
4950

same here.

This revision is now accepted and ready to land.Oct 30 2018, 10:10 PM
boris updated this revision to Diff 29939.Oct 31 2018, 6:20 AM
boris marked 2 inline comments as done.

Revision updated.

Harbormaster completed remote builds in B18469: Diff 29939.Oct 31 2018, 6:20 AM
Closed by commit rMOZILLACENTRAL16dc8e99aab0: Bug 1501116 - Part 6: Use alias for StylePathCommand. r=emilio (authored by boris). · Explain WhyOct 31 2018, 6:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
layout/
style/
1 line
servo/
components/
style/
gecko/
9 lines
properties/
6 lines

Diff 30208

View Options

layout/style/ServoBindings.toml

Loading...
View Options

servo/components/style/gecko/conversions.rs

Loading...
View Options

servo/components/style/properties/gecko.mako.rs

Loading...
Privacy · Cookies · Legal