Page MenuHomePhabricator

Bug 1502893 - Don't match document author rules if not needed for revalidation.
ClosedPublic

Authored by emilio on Oct 29 2018, 7:55 PM.

Details

Reviewers
heycam
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rMOZILLACENTRAL9f0e2fbf4d15: Bug 1502893 - Don't match document author rules if not needed for revalidation.
Bugzilla Bug ID
1502893
Summary

When you're in a ShadowRoot and can share style with a sibling, the sharing code
is smart enough to skip document author rules.

But then it could get confused if you also include document rules, since
revalidation selectors are matched against these.

This is not a correctness issue, because we're matching more than what we need,
and avoid sharing if we failed.

Also fix the detection for user rules in any_applicable_rule_data.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emilio created this revision.Oct 29 2018, 7:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2018, 7:55 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 29 2018, 7:55 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
emilio requested review of this revision.Oct 29 2018, 7:55 PM
emilio updated this revision to Diff 29271.Oct 29 2018, 7:58 PM

Make the crashtest not fire on load, since it's not needed

heycam accepted this revision.Nov 5 2018, 12:04 AM
This revision is now accepted and ready to land.Nov 5 2018, 12:04 AM
This revision was automatically updated to reflect the committed changes.