Bug 1430969: Ignore border-image-source when overriding document colors r=emilio
ClosedPublic
Actions

Authored by svoisen on Oct 28 2018, 9:45 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rMOZILLACENTRALdd74f656f209: Bug 1430969: Ignore border-image-source when overriding document colors r=emilio

Bugzilla Bug ID

1430969

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

svoisen created this revision.Oct 28 2018, 9:45 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2018, 9:45 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 28 2018, 9:45 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B17894: Diff 28940.Oct 28 2018, 9:45 PM

svoisen requested review of this revision.Oct 28 2018, 9:45 PM

Looks good, though we should add a test to layout/style/test/test_dont_use_document_colors.html.

servo/components/style/rule_tree/mod.rs
1294	Hmm, it's not great that we have these duplicated here, we should be able to do better. We have a static set of these properties in: https://searchfox.org/mozilla-central/rev/5b3b6b8fd9f90087f618c20382e631451136ed2b/servo/components/style/properties/properties.mako.rs#1160 We should be able to reuse it. Mind filing a follow-up for that?

Thanks for the quick review. I was wondering where the test should go – now it's glaringly obvious I should've dug around more. Will add.

servo/components/style/rule_tree/mod.rs
1294	Yeah, was a bit confused by this. Follow-up filed as bug 1502751.

In D10017#240076, @svoisen wrote:

Thanks for the quick review. I was wondering where the test should go – now it's glaringly obvious I should've dug around more. Will add.

Heh, fwiw I had to look around for a bit to find it... I didn't give up because I remember getting backed out for it in the past :P

Revision updated.

Harbormaster completed remote builds in B17907: Diff 28965.Oct 29 2018, 12:45 AM

svoisen added a child revision: D10024: Bug 1430969: Add tests for border-image-source blocking r=emilio.Oct 29 2018, 12:45 AM

svoisen mentioned this in D10024: Bug 1430969: Add tests for border-image-source blocking r=emilio.Oct 29 2018, 12:52 AM

Given the test is in the other revision, this looks good.

This revision is now accepted and ready to land.Oct 29 2018, 10:38 AM

Closed by commit rMOZILLACENTRALdd74f656f209: Bug 1430969: Ignore border-image-source when overriding document colors r=emilio (authored by svoisen). · Explain WhyOct 29 2018, 7:21 PM

This revision was automatically updated to reflect the committed changes.